Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add description for change_bid_public_key entry point #1479

Merged
merged 6 commits into from
Aug 9, 2024
Merged

add description for change_bid_public_key entry point #1479

merged 6 commits into from
Aug 9, 2024

Conversation

wojcik91
Copy link

What does this PR fix/introduce?

Adds a page describing the new change_bid_public_key entry point of system auction contract

@wojcik91 wojcik91 requested a review from ACStone-MTS as a code owner July 10, 2024 06:51
ACStone-MTS
ACStone-MTS approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@ACStone-MTS ACStone-MTS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor edits, otherwise looks good!

source/docs/casper/operators/becoming-a-validator/change-bid-public-key.md Outdated Show resolved Hide resolved
source/docs/casper/operators/becoming-a-validator/change-bid-public-key.md Outdated Show resolved Hide resolved
source/docs/casper/operators/becoming-a-validator/change-bid-public-key.md Outdated Show resolved Hide resolved
source/docs/casper/operators/becoming-a-validator/change-bid-public-key.md Outdated Show resolved Hide resolved
source/docs/casper/operators/becoming-a-validator/change-bid-public-key.md Outdated Show resolved Hide resolved
source/docs/casper/operators/becoming-a-validator/change-bid-public-key.md Outdated Show resolved Hide resolved
source/docs/casper/operators/becoming-a-validator/change-bid-public-key.md Outdated Show resolved Hide resolved
source/docs/casper/operators/becoming-a-validator/change-bid-public-key.md Outdated Show resolved Hide resolved
source/docs/casper/operators/becoming-a-validator/change-bid-public-key.md Outdated Show resolved Hide resolved
source/docs/casper/operators/becoming-a-validator/change-bid-public-key.md Outdated Show resolved Hide resolved
@ipopescu
Copy link
Collaborator

ipopescu commented Aug 5, 2024

Great content, @wojcik91. Are you planning to finish this PR?

@wojcik91
Copy link
Author

wojcik91 commented Aug 6, 2024

@ipopescu I apologize for the delay, I must have missed some notifications. The stuff you pointed out is now fixed.

ipopescu
ipopescu reviewed Aug 6, 2024
View reviewed changes
Copy link
Collaborator

@ipopescu ipopescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wojcik91, thank you for the updates. Could you please also change all deploys to transactions, including the casper-client command, which should use put-transaction? Please also test it.

Since deploy is deprecated, we are updating all 2.0 documentation to use transaction instead of deploy.

source/docs/casper/operators/becoming-a-validator/change-bid-public-key.md Outdated Show resolved Hide resolved
source/docs/casper/operators/becoming-a-validator/change-bid-public-key.md Outdated Show resolved Hide resolved
@wojcik91
Copy link
Author

wojcik91 commented Aug 7, 2024

@ipopescu I removed all references to deploys, but I still have one outstanding issue - the new put-txn command is in reality not a 1:1 translation of put-deploy.
I did actually use it to deploy a contract on devnet, but I did not figure out a way to correctly call installed contracts without using WASM code yet. Does some documentation for this command exist already?

@ipopescu
Copy link
Collaborator

ipopescu commented Aug 8, 2024

@ipopescu I removed all references to deploys, but I still have one outstanding issue - the new put-txn command is in reality not a 1:1 translation of put-deploy. I did actually use it to deploy a contract on devnet, but I did not figure out a way to correctly call installed contracts without using WASM code yet. Does some documentation for this command exist already?

Thanks, @wojcik91. This PR is ready for merging. We are still working on documentation for 2.0, including calling contracts. Let's merge this content and come back to the casper-client command once the docs for calling contracts are available.

@ipopescu ipopescu self-requested a review August 8, 2024 10:59
@ipopescu ipopescu merged commit d369c32 into casper-network:feat-2.0_docs Aug 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ACStone-MTS ACStone-MTS ACStone-MTS approved these changes

@ipopescu ipopescu ipopescu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wojcik91 @ipopescu @ACStone-MTS